Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(change): update messages.ts github links to formik/ org #754

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

yuriy636
Copy link
Contributor

@yuriy636 yuriy636 commented Jul 7, 2020

Not sure how you feel about this, but it surely took me by surprise the first time ("Have I installed the wrong package?")

Copy link
Collaborator

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. This would be a "change" rather than a "fix" though, as it's not a bugfix. There's some other places that need changing too (also: text says "let me know" instead of "let us know").

Although the entire transfer caught me by surprise as Jared never even told me about it (and has been unresponsive to email for months)... I've also been thinking TSDX deserves its own org for a while as can be seen in some of my comments in various places, particularly for permissions and making new repos, but the latter may well end up being monorepo.

@agilgur5 agilgur5 changed the title (fix): update messages.ts github links to /formik (fix): update messages.ts github links to formik/ org Jul 7, 2020
@jaredpalmer jaredpalmer merged commit b91ab47 into jaredpalmer:master Jul 8, 2020
@agilgur5 agilgur5 changed the title (fix): update messages.ts github links to formik/ org (change): update messages.ts github links to formik/ org Jul 12, 2020
@agilgur5
Copy link
Collaborator

@allcontributors please add @yuriy636 for code

@allcontributors
Copy link
Contributor

@agilgur5

I've put up a pull request to add @yuriy636! 🎉

paul-vd pushed a commit to EezyQuote/tsdx that referenced this pull request Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants