Upgrade from rollup-plugin-babel to @rollup/plugin-babel #789
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/formium/tsdx/ff7ar8nbs |
|
Also fixed Node CI / Lint on node 10.x and ubuntu-latest (pull_request) check. |
agilgur5
added
version: minor
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
agilgur5
changed the title
There was a problem hiding this comment.
@vladdy-moses thanks for the PR!
PR Suggestions
Please ensure to write a commit message and PR description next time; it would make reviewing a lot easier if you linked to the changelog and relevant breaking changes in your message. I've added the appropriate references in comments below.
A rationale would also be good to have. I assume this is just to get rid of a deprecation notice, however it would be better not to assume.
Changes Required
Please remove the CI change per the in-line comment. The rest of the comments are for reference.
Mergeability
This requires Node 10+, which also wasn't mentioned as a breaking change in the commit message. I've marked it as such and milestone'd it for v0.14.0 to go along with the other Node 10+ dep changes and official drop of Node <10 there.
agilgur5
added
problem: stale
agilgur5
force-pushed
the
update-rollup-babel-plugin
branch
from
8d49b04 to
4d2ad55
Compare
agilgur5
force-pushed
the
update-rollup-babel-plugin
branch
from
4d2ad55 to
4e925a1
Compare
|
Have taken over this myself since this has been stale for several weeks and is one of the last dep updates being added to I've removed the change I requested to be removed, rebased the PR and fixed the
Yup, seems to be so, got this warning on a fresh install of npm WARN deprecated rollup-plugin-babel@4.4.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-babel. |
BREAKING: requires Node 10+ - was getting a warning on install: - "npm WARN deprecated rollup-plugin-babel@4.4.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-babel." - c.f. https://github.com/rollup/plugins/blob/master/packages/babel/CHANGELOG.md#breaking-changes - `babelPlugin.custom` is now a separate export, `createBabelInputPluginFactory` - `babelHelpers: 'bundled'` was added - this is the default and backward-compatible with 4.x, but they recommended explicitly configuring it as such - c.f. https://github.com/rollup/plugins/blob/master/packages/babel/CHANGELOG.md#v510 - typings have been added to the package directly, no need to declare module to workaround lack of typings anymore - remove old commented out line referring to rollup-plugin-babel as well Co-Authored-By: Anton Gilgur <agilgur5@gmail.com>
agilgur5
force-pushed
the
update-rollup-babel-plugin
branch
from
4e925a1 to
edfc7f0
Compare
|
Removed the two leftover references to |
|
@allcontributors please add @vladdy-moses for code |
|
I've put up a pull request to add @vladdy-moses! 🎉 |
…#789) BREAKING: requires Node 10+ - was getting a warning on install: - "npm WARN deprecated rollup-plugin-babel@4.4.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-babel." - c.f. https://github.com/rollup/plugins/blob/master/packages/babel/CHANGELOG.md#breaking-changes - `babelPlugin.custom` is now a separate export, `createBabelInputPluginFactory` - `babelHelpers: 'bundled'` was added - this is the default and backward-compatible with 4.x, but they recommended explicitly configuring it as such - c.f. https://github.com/rollup/plugins/blob/master/packages/babel/CHANGELOG.md#v510 - typings have been added to the package directly, no need to declare module to workaround lack of typings anymore - remove old commented out line referring to rollup-plugin-babel as well Co-Authored-By: Anton Gilgur <agilgur5@gmail.com> Co-authored-by: Anton Gilgur <agilgur5@gmail.com>
No description provided.