Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update np to fix MFA bug during publishes #816

Merged
merged 1 commit into from
Aug 23, 2020

Conversation

agilgur5
Copy link
Collaborator

Description

  • previously it would always fail the last step or few because it had a
    bug with the MFA check
    • this has been fixed in a later version, so upgrade

Tags

c.f. sindresorhus/np#505 and v6.2.3 release notes

- previously it would always fail the last step or few because it had a
  bug with the MFA check
  - this has been fixed in a later version, so upgrade
@vercel
Copy link

vercel bot commented Aug 23, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/formium/tsdx/4uqpxcgg6
✅ Preview: https://tsdx-git-fork-agilgur5-update-np-fix-mfa.formium.vercel.app

Copy link
Collaborator Author

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn.lock changes are pretty big, but mostly validated that these are correct from reading the dep chain and also because np's release notes say it updated some dependencies as well

LGTM.

Should try this out for v0.13.3 before officially merging

@agilgur5
Copy link
Collaborator Author

Published all good 👍

@agilgur5 agilgur5 merged commit fff9a43 into jaredpalmer:master Aug 23, 2020
@agilgur5 agilgur5 added the scope: dependencies Pull requests that update a dependency file label Aug 23, 2020
paul-vd pushed a commit to EezyQuote/tsdx that referenced this pull request Dec 1, 2020
- previously it would always fail the last step or few because it had a
  bug with the MFA check
  - this has been fixed in a later version, so upgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant