-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multi-entry: temporarily change docs to singular "module" #862
Conversation
I spent ten minutes with adding globs and comma-separated paths before giving up going into the issues and searching/finding jaredpalmer#175 / jaredpalmer#367. Maybe delete the `(s)` until the issue is resolved to prevent other people from doing the same. :)
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/formium/tsdx/kq6i13w1b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, I fell victim to the same problem then dug into the code and wrote #367 (which was like my second or third PR as a contributor), hopefully this helps a bit.
The API docs are supposed to be equivalent to the --help
of each subcommand, so you'll need to modify the help text for both build
and watch
too:
https://github.com/formium/tsdx/blob/d4c3bb220bba4ab26545b9d1a09ef646f031bc63/src/index.ts#L366
Done, I simply used the "edit"-buttons in GitHub, guess you can squash when you merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the contribution @KATT . Yep, will squash merge this and edit commit message etc
@allcontributors please add @KATT for docs |
I've put up a pull request to add @KATT! 🎉 |
…r#862) - multi-entry is not currently supported due to a bug, PR to fix has yet to be merged - so modify docs that suggest it is supported from plural "Entry module(s)" to singular I spent ten minutes with adding globs and comma-separated paths before giving up going into the issues and searching/finding the bug and PR to fix the bug Maybe delete the `(s)` until the issue is resolved to prevent other people from doing the same. :)
I spent ten minutes with adding globs and comma-separated paths before giving up going into the issues and searching/finding #175 / #367.
Maybe delete the
(s)
until the issue is resolved to prevent other people from doing the same. :)