Added configuration options #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 21, 2018 13:32
* feature/enable-configuration: test(core): added tests for android tasks to check that options are respected feat(core): configured java task using constants for backwards compatibility feat(core): configured task for Android projects using options feat(core): added conditional logic to license generation/export based on inputs feat(core): added configuration options to license report task feat(configuration): added configuration class
| @@ -30,6 +30,8 @@ final class LicensePlugin implements Plugin<Project> { | |||
| // Get correct plugin - Check for android library, default to application variant for application/test plugin | |||
| final variants = getAndroidVariants(project) | |||
|
|
|||
| final configurationExtension = project.extensions.create("options", AndroidLicenseReportOptions) | |||
There was a problem hiding this comment.
We should probably change options to something more clear such as licenseReport or just license.
| compile DESIGN | ||
| } | ||
|
|
||
| project.extensions.configure(AndroidLicenseReportOptions, {options -> options.generateHtmlReport = false}) |
There was a problem hiding this comment.
Can you use the DSL directly?
project.extensions.options {
generateHtmlReport = false
generateJsonReport = false
copyHtmlReportToAssets = copyEnabled
copyJsonReportToAssets = copyEnabled
}
|
This is look great just a few comments and we need to update |
added 15 commits
January 21, 2018 22:20
…va projects" This reverts commit 6456732.
* feature/enable-configuration: doc(readme): added instructions for configuring the report tasks Revert "test(core): added tests to check the configuration affects Java projects" feat(configuration): added configuration options for java projects refactor(configuration): renamed variable for readability doc(core): updated Javadoc to properly detail the effects on Java projects test(core): added tests to check the configuration affects Java projects test(core): changed test to directly use licenseReport extension feat(configuration): renamed configuration
* feature/enable-configuration: refactor(core): renamed 'AndroidLicenseReportOptions' to 'LicenseReportOptions'
* feature/enable-configuration: doc(readme): wording changes in cofiguration example
* feature/enable-configuration: doc(readme): fixed incorrect closure name
|
I've made some changes to the PR.
Let me know about the README placement. I wasn't sure where the best place was. |
|
Released |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added configuration options to allow scripts to configure the following properties in Android projects:
Added tests to check that options are used by task.