Fix the index function use to work with new Sass versions. #2
Conversation
On failure index returns now null instead of false, but viewports always compares to false. This is easy to fix by taking a logical not of the resulting value. For more information see sass/sass#1127
Fix the index function use to work with new Sass versions.
|
Thanks a bunch! This does break on |
|
Damn, should also test with libsass, and it also sounds like libsass does something weird with booleans. It sounds quite logical that both false and null would result in true after boolean "not" operation, maybe should patch it as well... |
|
Yeah
|
|
ping @joelmertanen |
|
There is a workaround for libsass presented in sass/libsass#349, it appears that the libsass not is known to be broken. We can use this workaround to make viewports work on all versions at the same time. I'll create a new pull request for this. |
The not expression in libsass is somewhat broken, but there is a workaround presented in sass/libsass#349 which fixes this issue for us. It makes me feel a bit dirty, but so does a ruby dependency.
Make change in pull request #2 to also work on libsass.
On failure index returns now null instead of false, but viewports always
compares to false. This is easy to fix by taking a logical not of the resulting
value. For more information see sass/sass#1127