Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-platform build #1

Merged
merged 5 commits into from
May 17, 2022
Merged

Cross-platform build #1

merged 5 commits into from
May 17, 2022

Conversation

falkTX
Copy link
Contributor

@falkTX falkTX commented May 16, 2022

Now building and running on Linux 🎉

image

Sadly it crashes anytime a JIT operation is triggered, so it is not as useful.
The memofs for any call is just very suspiciously wrong.
I couldn't find why, sorry.

Allowing code to build is a good first step though, so here you go :)
In theory this should allow to build on macOS too, but I did not test this.

Signed-off-by: falkTX <falktx@falktx.com>
Signed-off-by: falkTX <falktx@falktx.com>
Signed-off-by: falkTX <falktx@falktx.com>
@jarikomppa
Copy link
Owner

Heh, this is pretty much exactly as far as I got when I started porting to linux.

Makefile Outdated
@@ -0,0 +1,91 @@
#!/usr/bin/make -f
# Makefile for FluidPlug #
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The what? =)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol copy&paste silliness, you didn't see anything 🌈

Makefile.mk Outdated
@@ -0,0 +1,297 @@
#!/usr/bin/make -f
# Makefile for DPF #
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

..

src/eval.cpp Outdated
@@ -727,14 +727,14 @@ std::string func2call(int func)
return s;
}

WELL512 random;
WELL512 wrandom;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this probably should be gRandom, my bad

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can change that, no worries.
It is just that we get a conflict with random function, leading to a build failure

Copy link
Owner

@jarikomppa jarikomppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small notes

Signed-off-by: falkTX <falktx@falktx.com>
Signed-off-by: falkTX <falktx@falktx.com>
@falkTX
Copy link
Contributor Author

falkTX commented May 17, 2022

just pushed fixes for the little issues you commented on.

@jarikomppa jarikomppa merged commit 0802c4e into jarikomppa:main May 17, 2022
@jarikomppa
Copy link
Owner

Thanks!

@jminor jminor mentioned this pull request Oct 29, 2022
@jminor
Copy link

jminor commented Oct 29, 2022

@falkTX I see a very similar crash on macOS. See #3 for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants