Skip to content

Commit

Permalink
qml: rename backClicked signal to back
Browse files Browse the repository at this point in the history
Renaming for consistency with other pages that 'back' signal and handles
the 'back' signal. No reason to have some pages call this differently.
  • Loading branch information
jarolrod committed Oct 26, 2024
1 parent 7b5f9c1 commit 3f94240
Show file tree
Hide file tree
Showing 8 changed files with 19 additions and 19 deletions.
6 changes: 3 additions & 3 deletions src/qml/pages/node/NodeSettings.qml
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ Item {
Component {
id: display_page
SettingsDisplay {
onBackClicked: {
onBack: {
nodeSettingsView.pop()
}
}
Expand All @@ -148,7 +148,7 @@ Item {
Component {
id: peers_page
Peers {
onBackClicked: {
onBack: {
nodeSettingsView.pop()
peerTableModel.stopAutoRefresh();
}
Expand All @@ -160,7 +160,7 @@ Item {
Component {
id: peer_details
PeerDetails {
onBackClicked: {
onBack: {
nodeSettingsView.pop()
}
}
Expand Down
6 changes: 3 additions & 3 deletions src/qml/pages/node/PeerDetails.qml
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@ import "../../components"

Page {
id: root
signal backClicked()
signal back()

property PeerDetailsModel details

Connections {
target: details
function onDisconnected() {
root.backClicked()
root.back()
}
}

Expand All @@ -27,7 +27,7 @@ Page {
leftItem: NavButton {
iconSource: "image://images/caret-left"
text: qsTr("Back")
onClicked: root.backClicked()
onClicked: root.back()
}
centerItem: Header {
headerBold: true
Expand Down
4 changes: 2 additions & 2 deletions src/qml/pages/node/Peers.qml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import "../../controls"
import "../../components"

Page {
signal backClicked
signal back
signal peerSelected(PeerDetailsModel peerDetails)

id: root
Expand All @@ -21,7 +21,7 @@ Page {
leftItem: NavButton {
iconSource: "image://images/caret-left"
text: qsTr("Back")
onClicked: root.backClicked()
onClicked: root.back()
}
centerItem: Header {
headerBold: true
Expand Down
4 changes: 2 additions & 2 deletions src/qml/pages/settings/SettingsBlockClockDisplayMode.qml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import "../../controls"
import "../../components"

Page {
signal backClicked
signal back

id: root
background: null
Expand All @@ -22,7 +22,7 @@ Page {
leftItem: NavButton {
iconSource: "image://images/caret-left"
text: qsTr("Back")
onClicked: root.backClicked()
onClicked: root.back()
}
centerItem: Header {
headerBold: true
Expand Down
2 changes: 1 addition & 1 deletion src/qml/pages/settings/SettingsConnection.qml
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ Item {
}
}
SettingsProxy {
onBackClicked: {
onBack: {
connectionSwipe.decrementCurrentIndex()
}
}
Expand Down
8 changes: 4 additions & 4 deletions src/qml/pages/settings/SettingsDisplay.qml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import "../../controls"
import "../../components"

Item {
signal backClicked
signal back

id: root

Expand All @@ -29,7 +29,7 @@ Item {
leftItem: NavButton {
iconSource: "image://images/caret-left"
text: qsTr("Back")
onClicked: root.backClicked()
onClicked: root.back()
}
centerItem: Header {
headerBold: true
Expand Down Expand Up @@ -70,15 +70,15 @@ Item {
Component {
id: theme_page
SettingsTheme {
onBackClicked: {
onBack: {
nodeSettingsView.pop()
}
}
}
Component {
id: blockclocksize_page
SettingsBlockClockDisplayMode {
onBackClicked: {
onBack: {
nodeSettingsView.pop()
}
}
Expand Down
4 changes: 2 additions & 2 deletions src/qml/pages/settings/SettingsProxy.qml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import "../../controls"
import "../../components"

Page {
signal backClicked
signal back

id: root

Expand All @@ -23,7 +23,7 @@ Page {
leftItem: NavButton {
iconSource: "image://images/caret-left"
text: qsTr("Back")
onClicked: root.backClicked()
onClicked: root.back()
}
centerItem: Header {
headerBold: true
Expand Down
4 changes: 2 additions & 2 deletions src/qml/pages/settings/SettingsTheme.qml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import "../../controls"
import "../../components"

Page {
signal backClicked
signal back

id: root
background: null
Expand All @@ -22,7 +22,7 @@ Page {
leftItem: NavButton {
iconSource: "image://images/caret-left"
text: qsTr("Back")
onClicked: root.backClicked()
onClicked: root.back()
}
centerItem: Header {
headerBold: true
Expand Down

0 comments on commit 3f94240

Please sign in to comment.