Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Characters not handled in the bookmark title #713

Closed
BarbzYHOOL opened this issue Feb 1, 2024 · 2 comments · Fixed by #715
Closed

Characters not handled in the bookmark title #713

BarbzYHOOL opened this issue Feb 1, 2024 · 2 comments · Fixed by #715
Labels
bug

Comments

@BarbzYHOOL
Copy link

BarbzYHOOL commented Feb 1, 2024 •
edited
Loading

Bug reports

image

Problem with some characters, I think it's only in the bookmark title

When I edit the bookmark it shows me "R�pertoire des articles relatifs �" but it should be "Répertoire des articles relatifs à" and it scrapped the name automatically
@LeXofLeviafan
Copy link
Collaborator

Well. Turns out that BeautifulSoup (the library used for parsing HTML) not only automatically converts the input to UTF-8 but also replaces the charset value in <meta> with it, thus invalidating any code that tries to read charset from <meta> 😅

LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Feb 1, 2024
@LeXofLeviafan
[jarun#713] fixed HTML encoding detection
fe76bd5
@LeXofLeviafan LeXofLeviafan mentioned this issue Feb 1, 2024
Merged
LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Feb 2, 2024
@LeXofLeviafan
[jarun#713] fixed HTML encoding detection
079c0c1
@jarun jarun closed this as completed in #715 Feb 3, 2024
jarun added a commit that referenced this issue Feb 3, 2024
@jarun
Merge pull request #715 from LeXofLeviafan/fix-encoding
b5a50b8 
[#713] fixed HTML encoding detection
@BarbzYHOOL
Copy link
Author

thx

@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[jarun#713] fixed HTML encoding detection LeXofLeviafan/buku
2 participants
@LeXofLeviafan @BarbzYHOOL