added 'netloc-tag' to URL_RENDER_MODE values #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeXofLeviafan
commented
Dec 15, 2024
| @@ -135,7 +135,7 @@ def _list_entry(self, context: Any, model: Namespace, name: str) -> Markup: | |||
| res += [f'<span class="netloc"> ({link(netloc, url_for_index_view_netloc)})</span>'] | |||
| if not parsed_url.scheme: | |||
| res += [f'<span class="link">{escape(model.url)}</span>'] | |||
| elif self.url_render_mode is None or self.url_render_mode == 'full': | |||
| elif self.url_render_mode == 'full': | |||
There was a problem hiding this comment.
No change in logic here; this property is actually implemented in a way that prevents returning None in the first place
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a "hybrid" option for
BUKUSERVER_URL_RENDER_MODE=setting (it's effectively identical tonetloc, except that the netloc-filter link is rendered as a "tag" – just like when using thefulloption). …It just looks cleaner, IMO.@jarun alternatively we could replace the
netlocoption with this – it does pretty much the exact same thing, after all; just retaining design used by the other option for the same element.Screenshots
The other options still work as before:
full/unsetnetloc