-
-
Notifications
You must be signed in to change notification settings - Fork 140
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
4 changed files
with
13 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2da9086
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eclipseo, @pabloariasal, @szlin, @zmwangx ddgr v1.8.1 is released! Kindly update the channels.
I had to bump the version because I missed updating the version number in 1.8 earlier. Sorry for any inconvenience.
2da9086
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jarun Uploaded, thanks for tagging me.
2da9086
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Lin!
2da9086
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zmwangx please update
ddgr
on PyPI.2da9086
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done updating, and I set up a bot so that in the future it wouldn't depend on me not missing Github notifications. https://github.com/zmwangx/pypi-release-bot/blob/master/.github/workflows/ddgr.yml
Btw sdist is broken, run https://github.com/zmwangx/pypi-release-bot/blob/a21fc7182f87919258e6b5b456165f0018e8dba5/.github/workflows/ddgr.yml#L28-L31 and you'll know why.
2da9086
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zmwangx!
For
sdist
broken issue, do I need to make any change in theddgr
project?2da9086
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to make sure
ddgr
exists before copying.ddgr/setup.py
Line 7 in 2da9086
2da9086
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please share the patch I can apply. I am not familiar with the dir structure in the server or how the files are accessed.
2da9086
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that should do.
2da9086
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!
Pushed at commit 5b7f806.