Skip to content

Commit

Permalink
Remove unnecessary error from New
Browse files Browse the repository at this point in the history
  • Loading branch information
Jascha Ephraim committed Oct 19, 2016
1 parent 0fd2fc0 commit a6402c5
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 10 deletions.
5 changes: 1 addition & 4 deletions example_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,7 @@ func Example() {
}

// Start LiveReload server
lr, err := lrserver.New(lrserver.DefaultName, lrserver.DefaultPort)
if err != nil {
log.Fatalln(err)
}
lr := lrserver.New(lrserver.DefaultName, lrserver.DefaultPort)
go lr.ListenAndServe()

// Start goroutine that requests reload upon watcher event
Expand Down
5 changes: 1 addition & 4 deletions lrserver_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,7 @@ type serverAlert struct {

func Test(t *testing.T) {
Convey("Given a new server", t, func() {
srv, err := lrserver.New(lrserver.DefaultName, 0)
if err != nil {
t.Fatal(err)
}
srv := lrserver.New(lrserver.DefaultName, 0)

Convey("StatusLog() and ErrorLog() should return loggers", func() {
logger := log.New(nil, "", 0)
Expand Down
4 changes: 2 additions & 2 deletions server.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ type Server struct {
}

// New creates a new Server instance
func New(name string, port uint16) (*Server, error) {
func New(name string, port uint16) *Server {
// Create router
router := http.NewServeMux()

Expand All @@ -48,7 +48,7 @@ func New(name string, port uint16) (*Server, error) {
// Handle reload requests
router.HandleFunc("/livereload", webSocketHandler(s))

return s, nil
return s
}

func (s *Server) ListenAndServe() error {
Expand Down

0 comments on commit a6402c5

Please sign in to comment.