Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In oldIE, iframes are never removed during History::stop #3015

Closed
akre54 opened this issue Feb 21, 2014 · 2 comments
Closed

In oldIE, iframes are never removed during History::stop #3015

akre54 opened this issue Feb 21, 2014 · 2 comments
Labels
bug

Comments

@akre54
Copy link
Collaborator

akre54 commented Feb 21, 2014

A new iframe is created on every History::start call, but never removed in History::stop, likely causing memory leaks on oldIE. (see #3006)
@akre54 akre54 added the bug label Feb 21, 2014
@jashkenas
Copy link
Owner

To be fair, you are never supposed to ever call stop. But sure.

@akre54
Copy link
Collaborator Author

akre54 commented Feb 21, 2014

Yeh not a huge bug but worth fixing probably.

@akre54 akre54 mentioned this issue Feb 27, 2014
Merged
jashkenas added a commit that referenced this issue Mar 4, 2014
@jashkenas
Merge pull request #3041 from braddunbar/iframe-cleanup
e0233d8 
Fix #3015 - History#stop cleans up iframe.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jashkenas @akre54