Collection#set style (Backwards Compatible) #3663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-2-1 Collection#add shouldn't parse a model instance
Mirrors the change in jashkenas#3512.
Splicing in a loop is the worst thing you can do: http://jsperf.com/insert-array-into-another-array/4
- [Base case (`#unshift`)](http://jsperf.com/insert-array-into-another-array/6) - ["Normal" collection size](http://jsperf.com/insert-array-into-another-array/8) - [Large collection](http://jsperf.com/insert-array-into-another-array/7)
jridgewell
force-pushed
the
collection-set-style-compat
branch
from
84b8071
to
0052c2f
Compare
| var singular = !_.isArray(models); | ||
| models = singular ? (models ? [models] : []) : models.slice(); | ||
| var id, model, attrs, existing, sort; | ||
| models = singular ? [models] : _.clone(models); |
There was a problem hiding this comment.
is clone faster here? Shouldn't it be quicker to avoid the logic branch in clone?
There was a problem hiding this comment.
Ha, didn't even notice I changed that.
|
👍 |
Closed
| @@ -1565,7 +1565,7 @@ | |||
| collection.on('sort', function() { | |||
| ok(true); | |||
| }); | |||
| collection.set([{id: 3}, {id: 2}, {id: 1}, {id: 0}]); | |||
| collection.set([{id: 1}, {id: 2}, {id: 3}, {id: 0}]); | |||
There was a problem hiding this comment.
What's the reason for this change?
There was a problem hiding this comment.
"Adding a model should trigger a sort". Seemed better to only add a model, as the mixed order case is handled in the test above.
There was a problem hiding this comment.
fair nuf. maybe split this out?
There was a problem hiding this comment.
Split it into what?
|
Changing |
jashkenas
added a commit
that referenced
this pull request
Aug 18, 2015
Collection#set style (Backwards Compatible)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backwards compatible version of #3648.
var ideclarations)modelsis nullishatan order of magnitude faster#unshift)#push)Depending on how much performance is an issue, we can use an even faster splice algorithm (also included in the jsperfs), it's just a bit complicated.