-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3941 return decoded hash in getHash() #3955
Conversation
compare correctly to cached fragment in navigate()
This seems fine to me. I'd say it could even be moved up into |
The methods |
I'm fine with this but it may be a minor breaking change. I'd consider it a bug fix personally though |
We added this to our project too 👍 |
This seems to break browsers 'back' navigation button. However, it does fix the above stated problem. |
Uh. |
It'd be great to have normalized hash decoding behavior, but the bit about breaking a browser's "back" button is highly concerning.
|
This issue is related to #4132 |
Rejecting this as it is a breaking change and it seems to cause worse problems than it aims to solve. |
...to compare correctly to cached fragment in navigate()