Fix navigate with replace: true and diacriticals/unicode characters in the hash #4175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the hash It seems there is a change in chrome 63 (also similarly introduced a while ago in some earlier version of iOS Safari) where the hash portion of the location.href is encoded, where it used to be decoded Fixes jashkenas#4085
|
Anyone reading this, I couldn't actually get the added unit tests to "successfully fail". The reason being, it seems that running in karma-chrome-launcher, the 'hashchange' event never actually fires so the checkUrl method isn't called. Despite this, I added the tests in the hope that somebody could figure that out. I can verify that the change does actually work by manually testing it in various contexts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems there is a change in chrome 63 (also similarly
introduced a while ago in some earlier version of iOS Safari) where the
hash portion of the location.href is encoded, where it used to be
decoded
Fixes #4085