Trigger the "changeId" event only if prevId is different from this.id. #4292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgonggrijp
requested changes
Sep 2, 2024
There was a problem hiding this comment.
Thank you for taking the effort to submit a fix, @Noodlex!
Could you please add a test that fails without your change, but passes with your change? Thanks in advance.
backbone.js
Outdated
| @@ -523,7 +523,9 @@ | |||
| if (this.idAttribute in attrs) { | |||
| var prevId = this.id; | |||
| this.id = this.get(this.idAttribute); | |||
| this.trigger('changeId', this, prevId, options); | |||
| if(this.id !== prevId) { | |||
There was a problem hiding this comment.
There needs to be a space here for consistency's sake.
Suggested change
| if(this.id !== prevId) { | |
| if (this.id !== prevId) { |
added 2 commits
September 2, 2024 14:13
jgonggrijp
approved these changes
Sep 2, 2024
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.