We no longer need to wrap in quotes JavaScript reserved words used as…

… properties (#4527)
jashkenas · Apr 24, 2017 · 7e35c2c · 7e35c2c
1 parent 5651b8b
commit 7e35c2c
Show file tree

Hide file tree

Showing 9 changed files with 41 additions and 54 deletions.
diff --git a/lib/coffeescript/browser.js b/lib/coffeescript/browser.js
diff --git a/lib/coffeescript/cake.js b/lib/coffeescript/cake.js
diff --git a/lib/coffeescript/coffeescript.js b/lib/coffeescript/coffeescript.js
diff --git a/lib/coffeescript/command.js b/lib/coffeescript/command.js
diff --git a/lib/coffeescript/nodes.js b/lib/coffeescript/nodes.js
diff --git a/lib/coffeescript/optparse.js b/lib/coffeescript/optparse.js
diff --git a/lib/coffeescript/repl.js b/lib/coffeescript/repl.js
diff --git a/src/nodes.coffee b/src/nodes.coffee
@@ -951,10 +951,7 @@ exports.Access = class Access extends Base
  name = @name.compileToFragments o
  node = @name.unwrap()
  if node instanceof PropertyName
- if node.value in JS_FORBIDDEN
- [@makeCode('["'), name..., @makeCode('"]')]
- else
- [@makeCode('.'), name...]
+ [@makeCode('.'), name...]
  else
  [@makeCode('['), name..., @makeCode(']')]
 
@@ -1781,9 +1778,6 @@ exports.Assign = class Assign extends Base
  if @variable.shouldCache()
  compiledName.unshift @makeCode '['
  compiledName.push @makeCode ']'
- else if fragmentsToText(compiledName) in JS_FORBIDDEN
- compiledName.unshift @makeCode '"'
- compiledName.push @makeCode '"'
  return compiledName.concat @makeCode(": "), val
 
  answer = compiledName.concat @makeCode(" #{ @context or '=' } "), val

diff --git a/test/modules.coffee b/test/modules.coffee
@@ -770,7 +770,7 @@ test "#4451: `default` in an export statement is only treated as a keyword when
  input = "export default { default: 1 }"
  output = """
  export default {
- "default": 1
+ default: 1
  };
  """
  eq toJS(input), output