Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CS2] object spread destructuring bug #4651

Closed
helixbass opened this issue Aug 17, 2017 · 3 comments
Closed

[CS2] object spread destructuring bug #4651

helixbass opened this issue Aug 17, 2017 · 3 comments
Labels
bug
Milestone
2.0.0

Comments

@helixbass
Copy link
Collaborator

This throws a compiler error:

{person: {mobile}, attrs...} = @props

Removing the @ or the attrs... spread param or the person: {mobile} destructured param all compile ok

@zdenko @GeoffreyBooth
@helixbass helixbass mentioned this issue Aug 17, 2017
Merged
@GeoffreyBooth GeoffreyBooth added this to the 2.0.0 milestone Aug 17, 2017
@GeoffreyBooth
Copy link
Collaborator

@zdenko do you mind looking into this?

@zdenko
Copy link
Collaborator

zdenko commented Aug 17, 2017

@GeoffreyBooth I'm checking this.

zdenko pushed a commit to GeoffreyBooth/coffeescript that referenced this issue Aug 18, 2017
fix object spread destructuring bug: jashkenas#4651
f9367ba
@zdenko zdenko mentioned this issue Aug 18, 2017
Merged
@connec connec mentioned this issue Aug 31, 2017
Closed
connec added a commit that referenced this issue Sep 1, 2017
@connec
Merge pull request #4652 from GeoffreyBooth/bug-fix-4651
5525b2b 
[CS2] Fix #4651: object spread destructuring bug
@connec
Copy link
Collaborator

connec commented Sep 1, 2017

Fixed by #4652.

@connec connec closed this as completed Sep 1, 2017
@GeoffreyBooth GeoffreyBooth mentioned this issue Sep 2, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
4 participants
@connec @helixbass @GeoffreyBooth @zdenko