Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CS2] Destructuring #4478

Merged
merged 21 commits into from
Apr 6, 2017
Merged

[CS2] Destructuring #4478

merged 21 commits into from
Apr 6, 2017

Commits on Mar 30, 2017

  1. Output simple array destructuring assignments to ES2015

    Chris Connelly committed Mar 30, 2017
    Configuration menu
    Copy the full SHA
    59959a6 View commit details
    Browse the repository at this point in the history

  2. Output simple object destructured assignments to ES2015

    Chris Connelly committed Mar 30, 2017
    Configuration menu
    Copy the full SHA
    b9f8f5d View commit details
    Browse the repository at this point in the history

  3. Compile shorthand object properties to ES2015 shorthand properties 

    This dramatically improves the appearance of destructured imports.
    Chris Connelly committed Mar 30, 2017
    Configuration menu
    Copy the full SHA
    066071f View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2017

  1. Compile default values in destructured assignment to ES2015

    Chris Connelly committed Apr 1, 2017
    Configuration menu
    Copy the full SHA
    2e0dab3 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2017

  1. Rename wrapInBraces to wrapInParentheses, and `compilePatternMatc… 

    …h` to `compileDestructuring`, for clarity; style improvements (no `==` or `!=`, etc.)
    @GeoffreyBooth
    GeoffreyBooth committed Apr 2, 2017
    Configuration menu
    Copy the full SHA
    a196614 View commit details
    Browse the repository at this point in the history

  2. Don’t confuse the syntax highlighter

    @GeoffreyBooth
    GeoffreyBooth committed Apr 2, 2017
    Configuration menu
    Copy the full SHA
    b11ba7f View commit details
    Browse the repository at this point in the history

  3. Comment Assign::compilePatternMatch a bit

    @lydell @GeoffreyBooth
    lydell authored and GeoffreyBooth committed Apr 2, 2017
    Configuration menu
    Copy the full SHA
    c5f7279 View commit details
    Browse the repository at this point in the history

  4. Assignment expressions in conditionals are a bad practice

    @GeoffreyBooth
    GeoffreyBooth committed Apr 2, 2017
    Configuration menu
    Copy the full SHA
    93c8f8e View commit details
    Browse the repository at this point in the history

  5. Optional check for existence that only checks !== undefined, not `!… 

    …= null`, to follow ES convention that default values only apply when a variable is undefined, not falsy
    @GeoffreyBooth
    GeoffreyBooth committed Apr 2, 2017
    Configuration menu
    Copy the full SHA
    8840aa9 View commit details
    Browse the repository at this point in the history

  6. The fallback destructuring code should apply default values only if `… 

    …undefined`, not falsy, to follow ES spec
    @GeoffreyBooth
    GeoffreyBooth committed Apr 2, 2017
    Configuration menu
    Copy the full SHA
    7786899 View commit details
    Browse the repository at this point in the history

  7. Add comments; remove unnecessary array splats in function tests

    @GeoffreyBooth
    GeoffreyBooth committed Apr 2, 2017
    Configuration menu
    Copy the full SHA
    1e6d910 View commit details
    Browse the repository at this point in the history

  8. Support destructuring in function parameters (first pass); catch dest… 

    …ructured reserved words
    @GeoffreyBooth
    GeoffreyBooth committed Apr 2, 2017
    Configuration menu
    Copy the full SHA
    6c814a0 View commit details
    Browse the repository at this point in the history

  9. Destructured variables in function parameter lists shouldn’t be added… 

    … to the function body with `var` declarations; treat splat array function parameters the legacy way to avoid rethinking jashkenas#4005
    @GeoffreyBooth
    GeoffreyBooth committed Apr 2, 2017
    Configuration menu
    Copy the full SHA
    5fc4e19 View commit details
    Browse the repository at this point in the history

  10. Remove redundancy in undefined-only check for existence; fix passing … 

    …option to check
    @GeoffreyBooth
    GeoffreyBooth committed Apr 2, 2017
    Configuration menu
    Copy the full SHA
    770ddcd View commit details
    Browse the repository at this point in the history

  11. Fix undefined redundancy

    @GeoffreyBooth
    GeoffreyBooth committed Apr 2, 2017
    Configuration menu
    Copy the full SHA
    d110b9a View commit details
    Browse the repository at this point in the history

  12. Simplify getting the variable name

    @GeoffreyBooth
    GeoffreyBooth committed Apr 2, 2017
    Configuration menu
    Copy the full SHA
    678e931 View commit details
    Browse the repository at this point in the history

  13. Reimplement “check for existence if not undefined” without creating a… 

    … new operator
    @GeoffreyBooth
    GeoffreyBooth committed Apr 2, 2017
    Configuration menu
    Copy the full SHA
    60f046e View commit details
    Browse the repository at this point in the history

  14. Obj::isAssignable should not mutate; pass lhs property in from `A… 

    …ssign` or `Code` to child arrays and objects so that those child nodes are set as allowable for destructuring
    @GeoffreyBooth
    GeoffreyBooth committed Apr 2, 2017
    Configuration menu
    Copy the full SHA
    05c1f46 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2017

  1. Merge branch '2' into destructuring 

    # Conflicts:
#	lib/coffeescript/lexer.js
    @GeoffreyBooth
    GeoffreyBooth committed Apr 3, 2017
    Configuration menu
    Copy the full SHA
    923b931 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2017

  1. Revert changes to tests

    @GeoffreyBooth
    GeoffreyBooth committed Apr 5, 2017
    Configuration menu
    Copy the full SHA
    bd8cf29 View commit details
    Browse the repository at this point in the history

  2. Restore revised test for empty destructuring assignment

    @GeoffreyBooth
    GeoffreyBooth committed Apr 5, 2017
    Configuration menu
    Copy the full SHA
    7e81fa0 View commit details
    Browse the repository at this point in the history