Fix #4491: import- and export-specific lexing should stop #4492
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4491 (I think)
I'm not really familiar with the
import
/export
syntax but it looks like the only the time that the import-/export-specific lexing controlled by@seenImport
/@seenExport
(which lexesas
,from
,default
differently) needs to continue beyond a line break is if we're inside a{...}
specifier list. So I added an@importSpecifierList
(corresponding to the existing@exportSpecifierList
), and unless one of these is set (indicating we're inside a specifier list) then seeing alineToken()
clears@seenImport
and@seenExport
Not sure if I should add additional tests for any of the other various
import
/export
syntaxes?