[CS2] return and export default can now accept implicit objects
#4532
Conversation
…ng snippet to where it’ll work in CS2
|
Very nice 👍 |
|
Well, it was previously a compiler error, so it’s not a breaking change. I guess the question is, are we opening ourselves up to allowing the compiler to output too much? Are there any edge cases where something indented on a new line after a |
| @@ -790,7 +790,7 @@ exports.Lexer = class Lexer | |||
| LINE_CONTINUER.test(@chunk) or | |||
| @tag() in ['\\', '.', '?.', '?::', 'UNARY', 'MATH', 'UNARY_MATH', '+', '-', | |||
| '**', 'SHIFT', 'RELATION', 'COMPARE', '&', '^', '|', '&&', '||', | |||
| 'BIN?', 'THROW', 'EXTENDS'] | |||
| 'BIN?', 'THROW', 'EXTENDS', 'DEFAULT'] | |||
There was a problem hiding this comment.
Out of interest, but would adding 'RETURN" here achieve the same thing as 75f6912?
There was a problem hiding this comment.
That was my first thought, but it's too permissive. This causes a return line continuation even if the line following the return is the same indentation, which we definitely don't want.
There was a problem hiding this comment.
Ah, good point, that makes sense!
|
Also merged into |
Fixes #1263, probably others. This now compiles:
As does the same for
export default.