[CS2] Un-prefer global #4543
Merged
[CS2] Un-prefer global #4543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uld try to run the locally-installed module if it exists, or the global version otherwise
lydell
reviewed
May 8, 2017
bin/cake
Outdated
| path.join(path.dirname(fs.realpathSync(__filename)), '../lib/coffeescript') | ||
| ]; | ||
|
|
||
| for (var i = 0; i < 4; i++) { |
There was a problem hiding this comment.
Why a hard coded 4 rather than potentialPaths.length?
There was a problem hiding this comment.
I was trying to be optimized, though I can see how this comes across as overkill. I toyed with a series of if statements to avoid even the unnecessary path manipulation lines, but testing didn't show a difference. I can make this more idiomatic if you think it's silly to hard-code the length to save 1ms.
bin/cake
Outdated
| path.join(process.cwd(), 'node_modules/coffeescript/lib/coffeescript'), | ||
| path.join(process.cwd(), 'node_modules/coffeescript/lib/coffee-script'), | ||
| path.join(process.cwd(), 'node_modules/coffee-script/lib/coffee-script'), | ||
| path.join(path.dirname(fs.realpathSync(__filename)), '../lib/coffeescript') |
There was a problem hiding this comment.
I know it was like this before, but why not use __dirname?
There was a problem hiding this comment.
Dunno. Was there a reason it was how it was before? Windows?
|
@lydell how about now? |
lydell
approved these changes
May 9, 2017
GeoffreyBooth
added a commit
to GeoffreyBooth/coffeescript
that referenced
this pull request
May 9, 2017
GeoffreyBooth
added a commit
that referenced
this pull request
May 14, 2017
mikermcneil
added a commit
to mikermcneil/grunt
that referenced
this pull request
Jul 13, 2017
For more information, see: • gruntjs#1556 (comment) • jashkenas/coffeescript#4543 • jashkenas/coffeescript@f661f91
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4049.
coffeeandcakecommands now first check if you have a locally-installed CoffeeScript module under the current path, and execute that version if so, similar to how Gulp works; and fall back to the global version otherwise.This enables using different versions of the CoffeeScript CLI on a per-project basis:
If you don’t have a globally-installed version, the
coffeeorcakecommands don’t do anything; you either have to use the locally-installed module via Node, like a normal module, or access the CLI via./node_modules/coffeescript/bin/coffee.