[CS2] use _extends utility instead of Object.assign() for object spreads #4675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
GeoffreyBooth
approved these changes
Aug 31, 2017
|
We should have a test that covers if a user creates a function named |
…ith our utility function
|
@helixbass I’ve added the test. Anyone else have any notes? @lydell or @connec? |
|
@GeoffreyBooth thanks for adding the addtl test and docs |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4674
This replaces the direct calls to
Object.assign()currently generated by object spreads with a call to a new utility function_extends(directly copied from Babel's equivalent, defaults to usingObject.assignwhen it's supported)Added
eqJS()test that_extendsis being generated and used when compiling object spread