Removed unnecessary check for passedExpectations truthiness

specDone events from Jasmine core will always have passedExpectations set to an array. The console reporter's own tests were the only caller that ever passed an event without a passedExpectations.
jasmine · Feb 15, 2020 · 4814296 · 4814296
1 parent 204e0a1
commit 4814296
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 8 deletions.
diff --git a/lib/reporters/console_reporter.js b/lib/reporters/console_reporter.js
@@ -211,7 +211,7 @@ function ConsoleReporter() {
     //
     // Same logic is used by jasmine.HtmlReporter, see https://github.com/jasmine/jasmine/blob/master/src/html/HtmlReporter.js
     if (result.failedExpectations.length === 0 &&
-        (!result.passedExpectations || result.passedExpectations.length === 0)) {
+      result.passedExpectations.length === 0) {
       printNewline();
       print(indent('Message:', 2));
       printNewline();

diff --git a/spec/reporters/console_reporter_spec.js b/spec/reporters/console_reporter_spec.js
@@ -206,7 +206,8 @@ describe("ConsoleReporter", function() {
           actual: true,
           stack: fakeStack
         }
-      ]
+      ],
+      passedExpectations: []
     });
 
     this.out.clear();
@@ -255,7 +256,8 @@ describe("ConsoleReporter", function() {
           actual: true,
           stack: fakeStack
         }
-      ]
+      ],
+      passedExpectations: []
     });
 
     this.out.clear();
@@ -286,7 +288,8 @@ describe("ConsoleReporter", function() {
           actual: true,
           stack: fakeStack
         }
-      ]
+      ],
+      passedExpectations: []
     });
 
     this.out.clear();
@@ -319,7 +322,8 @@ describe("ConsoleReporter", function() {
           actual: true,
           stack: undefined
         }
-      ]
+      ],
+      passedExpectations: []
     });
 
     this.out.clear();
@@ -354,7 +358,8 @@ describe("ConsoleReporter", function() {
           actual: true,
           stack: fakeStack
         }
-      ]
+      ],
+      passedExpectations: []
     });
 
     this.out.clear();
@@ -421,7 +426,8 @@ describe("ConsoleReporter", function() {
       status: "failed",
       description: "with a failing spec",
       fullName: "A suite with a failing spec that has no expectations",
-      failedExpectations: []
+      failedExpectations: [],
+      passedExpectations: []
     });
 
     this.out.clear();
@@ -449,7 +455,8 @@ describe("ConsoleReporter", function() {
         expected: false,
         actual: true,
         stack: undefined
-      }]
+      }],
+      passedExpectations: []
     });
 
     this.out.clear();