-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sqlalchemy #5
Merged
Merged
Sqlalchemy #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So.. I ripped all the manual SQL out and replaced it with a sqlalchemy ORM layer. It was messy and took a few days. There are probably a few new bugs.
Why bother? Let me step back a second and explain.
The UI to block whenever someone is talking
The UI should be usable while the log tail is active
I think it is import to be able to adjust voices while you play. Because its the way this stuff works, that means threads and/or multiple processes.
In my case the log tailing/talking is a second process. When you click attach it starts that second process, when you click detach it kill the process.
Not good enough. If it is chewing through logs and showing xp/min and fun stuff like that I don't want those to stop updating whenever it talks. So the actual talking part happens in a thread. That also means there has to be a way for the log reader to communicate with the talker. I'm using a queue for that. It's mostly a good approach; but the worst case is kind of ugg.
if there is a bunch of talking all at once (which happens in a few places in the game), it will dutifully recite each thing in the order in which it was received. That can take a long while and is annoying. I'll try and fix it at some point (non-trivial), but for most cases the current setup works nicely.
Sidekick is pretty cool and will be the direction of future development. It relegates voice_editor to a "voices" tab and adds a "character" tab intended to present live data. I'm fiddling with matplotlib and xp/inf graphs right now.
Other changes... I found out how to enable more TTS voices in windows 10. Notes in the README and a powershell script in the repo.
I added "Presets"; these make it easy to kick-start a more complicated voice for more constancy. There is a 'Zombie' preset for a creepy monster voice that works nicely for Vhz. I don't like having all the random npc citizens use the same voice, so I added 'Random Male' and 'Random Female' presets to make it easy to give them a little more variety.
I should add a robot preset for clockwork.. I'll do that now.