Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify.sh in 4.5.1 reporting TEDAPI Vitals Capabilities Incorrectly #515

Closed
SCHibbard opened this issue Sep 7, 2024 · 1 comment · Fixed by #516
Closed

verify.sh in 4.5.1 reporting TEDAPI Vitals Capabilities Incorrectly #515

SCHibbard opened this issue Sep 7, 2024 · 1 comment · Fixed by #516
Labels
bug Something isn't working

Comments

@SCHibbard
Copy link
Contributor

Just updated from 4.3.2 to 4.5.1. You all have been busy! Got TEDAPI connection working to get back vitals & alerts (yes!) After install, verify.sh reports " - TEDAPI Vitals: Not Connected", however docker logs pypowerwall reports "[INFO] TEDAPI Mode Enabled for Device Vitals (hybrid)".

Looks like in pypowerwall stats the value "pw3" was added between "tedapi" & "tedapi_mode", which messes with the sed command. I believe the line

TEDAPI=curl --silent http://localhost:$PORT/stats | sed 's/.*"tedapi": \(.*\), "tedapi_mode".*/\1/' 2>/dev/null

should be

TEDAPI=curl --silent http://localhost:$PORT/stats | sed 's/.*"tedapi": \(.*\), "pw3".*/\1/' 2>/dev/null

@jasonacox jasonacox added the bug Something isn't working label Sep 7, 2024
@jasonacox
Copy link
Owner

Great find, @SCHibbard - thank you!

jasonacox added a commit that referenced this issue Sep 7, 2024
Fix verify.sh and update pypowerwall #515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants