Various updates inspired by recent issues #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nown address fails
…try_limit and connection_retry_delay respectively) from the Device() constructor
|
Tests look clean. Updated docs and bump to v1.12.10. |
|
Thanks, @uzlonewolf ! 🙏 |
jasonacox
reviewed
Sep 1, 2023
| @@ -885,19 +929,23 @@ def _get_socket(self, renew): | |||
| "socket unable to connect (timeout) - retry %d/%d", | |||
| retries, self.socketRetryLimit | |||
| ) | |||
| err = ERR_OFFLINE | |||
There was a problem hiding this comment.
I don't know how I missed this. This stepped on the exception local variable err which it won't allow. Regardless, we shouldn't have had err for the exception anyway since it is used within the function already. Renaming to e.
See #402 - Thanks @simon-kuzin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of these are fairly minor, though "Scan for new IP address then auto-IP is used and connection to last-known address fails" and "Make connection/key errors more descriptive" are pretty big.