This repository has been archived by the owner on May 10, 2023. It is now read-only.
update scope for new ink version #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jasongilman would it be possible to make Ink a required dependency now? The alternative code path that doesn't use Ink for the REPL seems a bit fragile (i.e. #229 seems to have re-appeared after being fixed) |
|
Alright, we've added a shim to work around this in the new ink release: JunoLab/atom-ink@cb9bc4d |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update to ensure proto-repl's compatibility with the next ink version.
JunoLab/atom-ink#127 broke the hack of adding a class to the result directly via
r.view.classList.addand introduced ascopekeyword for theResultconstructor instead.It would also make sense to adapt your stylesheets to use the adaptive width introduced in the abovementioned PR. Should you run into any troubles with ink master feel free to ping me. :)