fix for missing connection change event #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 24, 2017 16:50
jasongin
reviewed
Nov 27, 2017
| // make sure we get the correct length by appending 000... | ||
| let deviceUuid = sender.bluetoothAddress.toString(16); | ||
| if (deviceUuid.length < 12) { | ||
| deviceUuid = Array(12 - deviceUuid.length + 1).join('0') + deviceUuid; |
There was a problem hiding this comment.
In _onAdvertisementWatcherReceived, the deviceUuid is generated by these two lines of code:
let address = formatBluetoothAddress(e.bluetoothAddress);
let deviceUuid = address.replace(/:/g, '');
The result is the same, so it doesn't matter which way it's done, but I'd prefer it to be consistent in the two places. Maybe add a new helper function?
|
The CI is just complaining that node version 5 is no longer supported. Other versions succeeded. I need to remove version 5 (and 7) from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi realized that i had no disconnect events on windows. After debugging it i realized that my device was stored as
00000190a0c2in_deviceMapbut doingsender.bluetoothAddress.toString(16)in_onConnectionStatusChangedwas only returning190a0c2This PR fixes this by appending zeros