Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

view all in inbox not remembered across actions #49

Closed
inliniac opened this issue May 1, 2017 · 6 comments
Closed

view all in inbox not remembered across actions #49

inliniac opened this issue May 1, 2017 · 6 comments

Comments

@inliniac
Copy link

inliniac commented May 1, 2017

By default inbox shows 100 events. At the top it says 'Showing 1-100 of 173.' I use the Drop down on the left to show all: 'view all'. Now I see 'Showing 1-173 of 173'.

When I archive an event, it jumps back to 'Showing 1-100 of 172.'.

Expected behavior: remember 'view all'.

Not sure how the user should be able to revert the option though. Perhaps replace the 'view all' by 'view 100' or something similar when viewing all.

jasonish added a commit that referenced this issue May 1, 2017
@jasonish
Copy link
Owner

jasonish commented May 1, 2017

Did a quick fix that at least keeps it at view all after hitting the archive button. But overall the UI could use some improvement in this area.

@jasonish
Copy link
Owner

jasonish commented May 4, 2017

Close now. I've added a user configurable setting to set the number of alerts per page, You can set it up to 500. Still ripe for improvement, but at least I think this issue is solved.

@jasonish jasonish closed this as completed May 4, 2017
@inliniac
Copy link
Author

inliniac commented May 5, 2017

Upgrade path isn't very clean yet. Inbox doesn't show anything unless you first to go settings and select an amount from the drop down. It should probably use a default if the value is missing.

@jasonish
Copy link
Owner

jasonish commented May 5, 2017

Thats because I didn't test on Firefox. Fix in build.

@inliniac
Copy link
Author

inliniac commented May 5, 2017 via email

@jasonish
Copy link
Owner

jasonish commented May 5, 2017

ah, maybe I had some local state, anyways, it was bad javascript that appeared to work in chrome, but not firefox... but given I normally use chrome, I may have had some local state causing it to not fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants