cron job trigger on timezone based, daylightsaving taken care #40
Conversation
gocron.go
Outdated
| @@ -128,27 +132,28 @@ func (j *Job) Do(jobFun interface{}, params ...interface{}) { | |||
| func (j *Job) At(t string) *Job { | |||
| hour := int((t[0]-'0')*10 + (t[1] - '0')) | |||
| min := int((t[3]-'0')*10 + (t[4] - '0')) | |||
| if hour < 0 || hour > 23 || min < 0 || min > 59 { | |||
| sec := int((t[6]-'0')*10 + (t[7] - '0')) | |||
| if hour < 0 || hour > 23 || min < 0 || min > 59 || sec < 0 || sec > 59 { | |||
There was a problem hiding this comment.
This does not handle leap seconds.
There was a problem hiding this comment.
Can you elaborate a bit? I suppose leap second is beyond scope of gocron lib as the job gets triggered when at specified time in seconds. After the leap second, since time resets back and job is already triggered, so no issues.
Apologies for responding after years. :)
There was a problem hiding this comment.
The library doesn't support winter/summer time changes that happen twice per year causing trigger to be missed completely once per year or triggered at wrong hour, leap seconds is surely something much less important than that.
README.md
Outdated
| @@ -46,9 +50,9 @@ func main() { | |||
| gocron.Every(1).Monday().Do(task) | |||
| gocron.Every(1).Thursday().Do(task) | |||
|
|
|||
| // function At() take a string like 'hour:min' | |||
| gocron.Every(1).Day().At("10:30").Do(task) | |||
There was a problem hiding this comment.
I think it is still valuable to have this line here as an example of what you can use.
It isn't always clear what you do need and don't need when you're learning a new language.
There was a problem hiding this comment.
I agree. It can be retained.
|
Hello @laxmanvallandas :) this is a feature I find myself in need of with this package. Do you think you can rebase and clean this up a bit so it can be considered to be merged into master? |
|
Sure. Please give me sometime. It's been a while i looked into this. Will
rebase and update the changes.
Thanks & Regards
Laxman Vallandas
…On Fri, 2 Aug, 2019, 12:38 AM Sergiu Ghitea, ***@***.***> wrote:
Hello @laxmanvallandas <https://github.com/laxmanvallandas> :) this is a
feature I find myself in need of with this package. Do you think you can
rebase and clean this up a bit so it can be considered to be merged into
master?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#40?email_source=notifications&email_token=ABDHZ2622ZWX6VOTLDXXQJ3QCMYCTA5CNFSM4DPRQ6L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3LS5AI#issuecomment-517418625>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABDHZ23C4WNZJYMVTQJ5Z3LQCMYCTANCNFSM4DPRQ6LQ>
.
|
|
Thank you @laxmanvallandas ! If you need some help please let me know :) |
No description provided.