Fix Handlebars.SafeString deprecation message in ember 2.8.x #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonmit
reviewed
Oct 10, 2016
| @@ -16,7 +16,7 @@ const { | |||
| } = Ember; | |||
|
|
|||
| function isSafeString(input) { | |||
| return (typeof isHTMLSafe === 'function' && isHTMLSafe(input)) || (input instanceof Handlebars.SafeString); | |||
| return (typeof isHTMLSafe === 'function' && isHTMLSafe(input)) || (input && typeof input.toHTML === 'function'); | |||
There was a problem hiding this comment.
toHTML doesn't look to be safe
emberjs/ember.js#13318 (comment)
There was a problem hiding this comment.
Yeah. I see that the code is being used in the isHTMLSafe function itself inside ember https://github.com/emberjs/ember.js/blob/aeeddf7c00b42a340494465252481b5414d87009/packages/ember-glimmer/lib/utils/string.js
So the changes in my commit are actually duplicated. I guess the best way would be to just use the isHTMLSafe function for ember versions that support it, and only use instanceof SafeString in older ember versions that will not throw a deprecation message.
Maybe something like this:
function isSafeString(input) {
if (typeof isHTMLSafe === 'function') {
return isHTMLSafe(input);
}
return input instanceof Handlebars.SafeString;
}
tehmaestro
force-pushed
the
safestring-fix
branch
from
b6b4628 to
0afac21
Compare
|
LGTM, thanks @tehmaestro Tests failing for non-related reasons so I'll merge and version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from: https://github.com/workmanw/ember-string-ishtmlsafe-polyfill
Discussion here: emberjs/ember.js#13318