fixed generating single quote erlang config file #5
Conversation
Enabled booleans and numbers in configuration
|
replaced |
version 0.1.0
|
my latest changes i marked this version as |
|
@jasonroyle, @Raffaello, I was wondering what was the status on this. I am keen on seeing the cluster creation parts improved in this role and it would be great if these improvements could be merged into the main package. Is there anything in particular that is holding this up? |
There was a problem hiding this comment.
I think it would be nice to sort out the vhost and the user management issues before merging this. This might be difficult to test unless running the role on a clean VM, so it would be good to have a test setup similar to how it is described in https://www.ansible.com/blog/testing-ansible-roles-with-docker, but this may out of scope for this PR.
|
|
||
| - include: vhosts.yml | ||
|
|
||
| - include: users.yml |
There was a problem hiding this comment.
As I noted in #6, this will fail when creating new users (at least it did for me). It would be good to only run this on the master node.
| owner: rabbitmq | ||
| group: rabbitmq | ||
| mode: 0400 | ||
| when: rabbitmq_erlang_cookie is defined |
There was a problem hiding this comment.
I like this. It will make it easy to make the erlang_cookie setting optional. You only really want to set it once, during the initial setup and when doing maintenance updates it might be a good idea to leave it out.
This of course may introduce a problem when adding new nodes to the cluster. But I guess that this is a good enough trade-off in this case.
There was a problem hiding this comment.
yes it could be a problem adding new nodes. It should be more parametrized, but still for a new node you still can define that cookie from ansible CLI, so it should be possible.
|
|
||
| - include: node_fullstart.yml | ||
|
|
||
| - include: vhosts.yml |
There was a problem hiding this comment.
now with ansible 2.4 there should be improvements on these rabbitmq functions. Also it should support TLS that was a requirements for me with this role, so until ansible 2.3 there were issues with TLS and certificates. Now those should be fixed. Not sure. I suspended working on this one.
|
@aignas I suspended the work on this role at the moment, i might reprise if there are new goals to achieve. |
|
Hi guys, I like to be quite thorough when accepting pull requests and testing it all first but I just haven't got round to doing this just yet, I do still intend to come back to it at some point but my concentration has been elsewhere. |
|
@jasonroyle, I'd like to become a collaborator, so let me know how we can work on it. :) |
|
@jasonroyle me too, I would like to be a collaborator. @aignas I do not have really too much time now to work on those changes you have requested. I do not neither remember now and i do not have your perspective on those one. It means at this present time it is impossible for me to commit those changes. I will be back to work on this in the near future probably, not sure when might be a week or a little bit longer. I can try in free time, but those |
|
@aignas I think: The solution it would be merging this one, tag this actual version publish to ansible galaxy, and moving forward from this. so you will work from this point on the changes you requested. We can do evolutionary, version based role. canot do to many changes in 1 PR. |
|
Hi @aignas, could you please fix the user issue reported here so it would be possible to make it ready to merge this one? I do not have time now. @jasonroyle Should we consider to make PR against ansible >= 2.4 only? because for rabbitMQ modules there are some improvements with 2.4 especially for TLS |
|
@aignas for the test related: i might can do with a full VM, docker container and rabbitmq managed with systemd doesn't work (it is stuck on systemd start rabbitmq-server) and anyway when reach that level make sense using the rabbitmq docker image not a "clean OS" to provision. Also it would not be a real test scenario, i guess the scope and goal of this Role is to provision a full OS not a container. |
this fixes #4
also please after merging tag a new version and upload to ansible-galaxy.
it is reported here:
picotrading/ansible-rabbitmq#1
thanks