[compiler] Allow ref access in callbacks passed to event handler props#1
Open
jasonyuezhang wants to merge 1 commit intomainfrom
Open
[compiler] Allow ref access in callbacks passed to event handler props#1jasonyuezhang wants to merge 1 commit intomainfrom
jasonyuezhang wants to merge 1 commit intomainfrom
Conversation
Fixes a false positive where the compiler incorrectly flags ref access
in callbacks passed to event handler wrappers on built-in DOM elements.
For example, with react-hook-form:
<form onSubmit={handleSubmit(onSubmit)}>
Where onSubmit accesses ref.current, this was incorrectly flagged as
"Cannot access refs during render". This is a false positive because
built-in DOM event handlers are guaranteed by React to only execute in
response to actual events, never during render.
This fix only relaxes validation for built-in DOM elements (not custom
components) to maintain safety. Custom components could call their onFoo
props during render, which would violate ref access rules.
Adds four test fixtures demonstrating allowed and disallowed patterns.
Issue: facebook#35040
Allow functions that access refs to be passed to built-in DOM event handler props while still rejecting direct ref values in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes facebook#35040. The React compiler incorrectly flags ref access within event handlers as ref access at render time. For example, this code would fail to compile with error "Cannot access refs during render":
This is a false positive because any built-in DOM event handler is guaranteed not to run at render time. This PR only supports built-in event handlers because there are no guarantees that user-made event handlers will not run at render time.
How did you test this change?
I created 4 test fixtures which validate this change:
All linters and test suites also pass.
Copied from facebook#35062
Original PR: facebook#35062