fix(v4): rate limit is null when GHE has no rate limit settings

jasperapp · Oct 6, 2020 · 5ca0405 · 5ca0405
1 parent 6116c67
commit 5ca0405
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/Renderer/Library/GitHub/V4/GitHubV4Client.ts b/src/Renderer/Library/GitHub/V4/GitHubV4Client.ts
@@ -61,6 +61,8 @@ export class GitHubV4Client {
  }
 
  private async waitRateLimit(data: RemoteGitHubV4Entity) {
+ // GHEの場合、rateLimitが設定されていない場合がある
+ if (!data.rateLimit) return;
  if (data.rateLimit.remaining > 0) return;
 
  const resetAtMillSec = new Date(data.rateLimit.resetAt).getTime();

diff --git a/src/Renderer/Library/Type/RemoteGitHubV4/RemoteGitHubV4Entity.ts b/src/Renderer/Library/Type/RemoteGitHubV4/RemoteGitHubV4Entity.ts
@@ -4,5 +4,5 @@ export type RemoteGitHubV4Entity = {
  limit: number;
  remaining: number;
  resetAt: string; // YYYY-MM-DDThh:mm:ssZ
- }
+ } | null
 }