fix: macOS tests & use LIBS instead of LDFLAGS #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LDFLAGS applies to everything including later user builds (e.g. building a wheel) LDFLAGS_NODIST could be used but is probably unnecessary (also applies to cpython stdlib C modules which is probably unwanted) LIBS only applies to the python executable and libpython library, this is most likely enough. https://docs.python.org/3/using/configure.html#envvar-LIBS
| @@ -31,7 +31,7 @@ class UbuntuPythonBuilder : NixPythonBuilder { | |||
| $pythonBinariesLocation = $this.GetFullPythonToolcacheLocation() | |||
|
|
|||
| ### To build Python with SO, passing relative path W.r.t to the binary location. | |||
| $env:LDFLAGS="-Wl,-rpath='`$`$ORIGIN/../lib'" | |||
| $env:LIBS = "-Wl,--enable-new-dtags,-rpath='`$`$ORIGIN/../lib'" | |||
There was a problem hiding this comment.
What's the benefit of LIBS over LDFLAGS?
There was a problem hiding this comment.
that's in the commit message:
LDFLAGS applies to everything including later user builds (e.g. building a wheel)
LDFLAGS_NODIST could be used but is probably unnecessary (also applies to cpython stdlib C modules which is probably unwanted)
LIBS only applies to the python executable and libpython library, this is most likely enough. https://docs.python.org/3/using/configure.html#envvar-LIBS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple fixes for actions#275
Build (rebased on upstream main): https://github.com/mayeut/python-versions/actions/runs/11767364478