Update README.md: removes faker import confusion #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creating both a variable and import name `faker` is confusing and lead me wondering where the docs where for these functions like `.Person()` Took some careful inspection to realize you're hiding the faker import with a faker variable. Consider this change set to make it more legible and clear about what is going on.
jaswdr
approved these changes
Sep 30, 2022
|
LGTM |
|
Merged, @MaerF0x0 thank you for catching this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
creating both a variable and import name
fakeris confusing and lead me wondering where the docs where for these functions like.Person()Took some careful inspection to realize you're hiding the faker import with a faker variable.
Consider this change set to make it more legible and clear about what is going on.
Description
Replace this line with a short description of your changes
Are you trying to fix an existing issue?
Replace this line with a link to the issue you are trying to fix
Go Version
Go Tests