Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 70 #153

Merged
merged 6 commits into from
Oct 9, 2023
Merged

Issue 70 #153

merged 6 commits into from
Oct 9, 2023

Conversation

jaswdr
Copy link
Owner

@jaswdr jaswdr commented Oct 9, 2023

Description

  1. Generate valid Bitcoin and Ethereum addresses.
  2. Deprecate P2PKHAddress, P2PKHAddressWithLength, P2SHAddress, P2SHAddressWithLength, Bech32Address, Bech32AddressWithLength methods.

Are you trying to fix an existing issue?

Replace this line with a link to the issue you are trying to fix

Go Version

$ go version
go version go1.21.1 linux/amd64

Go Tests

$ go test
2023/10/09 19:47:42 Error while requesting https://loremflickr.com/300/200 : request failed
2023/10/09 19:47:42 Error while creating a temp file: temp file creation failed
2023/10/09 19:47:42 Error while requesting https://randomuser.me : request failed
2023/10/09 19:47:42 Error while creating a temp file: temp file creation failed
PASS
ok      github.com/jaswdr/faker 2.490s

@jaswdr jaswdr merged commit a20ac58 into master Oct 9, 2023
67 checks passed
@jaswdr jaswdr deleted the issue-70 branch October 9, 2023 19:03
@jaswdr jaswdr mentioned this pull request Oct 9, 2023
Closed
@Emyrk
Copy link

Emyrk commented Oct 9, 2023

Does this work by only returning 1 of 10 possible addresses?

jaswdr pushed a commit that referenced this pull request Oct 10, 2023
Revert "Issue 70 (#153)"
7d1b26a 
This reverts commit a20ac58.
jaswdr added a commit that referenced this pull request Oct 10, 2023
@jaswdr
Revert changes done to crypto to make it less random (#154)
d2fb71c 
* Revert "Issue 70 (#153)"

This reverts commit a20ac58.

* Deprecate Bech32AddressWithLength, Bech32Address, P2SHAddress, P2PKHAddressWithLength, P2PKHAddress

---------

Co-authored-by: Jonathan Schweder <jonathanschweder@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaswdr @Emyrk