Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix intn panic #163

Merged
merged 2 commits into from
Jan 20, 2024
Merged

fix intn panic #163

merged 2 commits into from
Jan 20, 2024

Conversation

jaswdr
Copy link
Owner

@jaswdr jaswdr commented Jan 20, 2024 •
edited
Loading

based on #160

  • faker: fix panic from int wraparound when Intn(math.MaxInt+1)
  • Refactoring code, renaming rndInt to value and removing unreachable code

@jaswdr jaswdr enabled auto-merge (squash) January 20, 2024 12:58
@jaswdr jaswdr merged commit 4f477b6 into master Jan 20, 2024
22 checks passed
@jaswdr jaswdr deleted the fix-intn-panic branch January 20, 2024 12:59
@jaswdr jaswdr mentioned this pull request Jan 20, 2024
Closed
jaswdr added a commit that referenced this pull request Jan 23, 2024
@jaswdr
Revert "fix intn panic (#163)"
ed3b14c 
This reverts commit 4f477b6.
jaswdr added a commit that referenced this pull request Jan 23, 2024
@jaswdr
Revert "fix intn panic (#163)" (#165)
ae23891 
This reverts commit 4f477b6.
jaswdr added a commit that referenced this pull request Feb 16, 2024
@jaswdr
fix intn panic (#163)
4d8a0f4 
This reverts commit ae23891.
jaswdr added a commit that referenced this pull request Feb 16, 2024
@jaswdr
Re-apply fix intn panic (introduced in #163) (#166)
d66c622 
This reverts commit ae23891.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaswdr @sean-