Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update old field classification naming #107

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

jatkinson1000
Copy link
Owner

To be consistent with old indoor classification naming.

@TomHall2020
Copy link
Contributor

Yup, I definitely would have wanted to make that rename as part of the structure of #103 but good to have it locked in place already and I wouldn't have caught renaming the test functions and extra bits of documentation.

@jatkinson1000 jatkinson1000 force-pushed the old_agb_naming_consistency branch from 4f5fb06 to 70cd955 Compare December 15, 2024 15:30
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.81%. Comparing base (e0d8d00) to head (70cd955).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #107   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files          30       30           
  Lines        1742     1742           
=======================================
  Hits         1704     1704           
  Misses         38       38           
Files with missing lines Coverage Δ
archeryutils/classifications/__init__.py 100.00% <ø> (ø)
...s/classifications/agb_old_field_classifications.py 100.00% <100.00%> (ø)
...cheryutils/classifications/tests/test_agb_field.py 100.00% <ø> (ø)
...yutils/classifications/tests/test_agb_old_field.py 100.00% <100.00%> (ø)

@jatkinson1000 jatkinson1000 merged commit 470d14e into main Dec 15, 2024
15 checks passed
@jatkinson1000 jatkinson1000 deleted the old_agb_naming_consistency branch December 15, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants