Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Fest Assert reference #66

Closed
Capstan opened this issue Oct 28, 2019 · 0 comments · Fixed by #67
Closed

Update Fest Assert reference #66

Capstan opened this issue Oct 28, 2019 · 0 comments · Fixed by #67
Assignees
@Capstan
Labels
enhancement

Comments

@Capstan
Copy link
Contributor

Capstan commented Oct 28, 2019

https://mvnrepository.com/artifact/org.easytesting/fest-assert/1.4 is very old and looks to be unmaintained. The http://fest.easytesting.org site now tries to sell you sesamin (a sesame-seed-based compound). There's no obvious source location, making it difficult to build from source inside Google's monorepo.

Figure out its successor and update tests accordingly.

One hint is from alexruiz/fest-assert-2.x#167 (comment) where one of the main contributors points would-be user to AssertJ.
@Capstan Capstan self-assigned this Oct 28, 2019
Capstan added a commit to Capstan/json-schema-core that referenced this issue Oct 28, 2019
@Capstan
Upgrade Fest Assert to AssertJ.
95b85e8 
Also re-ordered one `overridingErrorMessage` to be applied before the assert evaluation.

Fixes java-json-tools#66.
Capstan added a commit to Capstan/json-schema-core that referenced this issue Oct 28, 2019
@Capstan
Upgrade Fest Assert to AssertJ.
d5782c9 
Also re-ordered one `overridingErrorMessage` to be applied before the assert evaluation.

Fixes java-json-tools#66.
@Capstan Capstan mentioned this issue Oct 28, 2019
Merged
Capstan added a commit that referenced this issue Oct 28, 2019
@Capstan
Upgrade Fest Assert to AssertJ.
1c7682d 
Also re-ordered one `overridingErrorMessage` to be applied before the assert evaluation.

Fixes #66.
Capstan added a commit to Capstan/json-schema-validator that referenced this issue Nov 5, 2019
@Capstan
Upgrade Fest Assert to AssertJ.
064d4be 
Also re-ordered one `overridingErrorMessage` to be applied before the assert evaluation.

Same fixes as for java-json-tools/json-schema-core/issues/66.
@Capstan Capstan mentioned this issue Nov 5, 2019
Merged
Capstan added a commit to java-json-tools/json-schema-validator that referenced this issue Nov 5, 2019
@Capstan
Upgrade Fest Assert to AssertJ.
7788ffe 
Also re-ordered one `overridingErrorMessage` to be applied before the assert evaluation.

Same fixes as for java-json-tools/json-schema-core/issues/66.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Capstan Capstan

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade Fest Assert to AssertJ. Capstan/json-schema-core
1 participant
@Capstan