Fix free_callback JNI weak reference leak

java-native-access · Jan 9, 2024 · 4bf9f92 · 4bf9f92
1 parent 1dd63c8
commit 4bf9f92
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/native/callback.c b/native/callback.c
@@ -154,7 +154,7 @@ create_callback(JNIEnv* env, jobject obj, jobject method,
   for (i=0;i < argc;i++) {
     int jtype;
     jclass cls = (*env)->GetObjectArrayElement(env, arg_classes, i);
-    if ((cb->conversion_flags[i] = get_conversion_flag(env, cls)) != CVT_DEFAULT) {
+    if (direct && ((cb->conversion_flags[i] = get_conversion_flag(env, cls)) != CVT_DEFAULT)) {
       cb->arg_classes[i] = (*env)->NewWeakGlobalRef(env, cls);
       cvt = 1;
     }