Invalid field order on XResizeRequestEvent

[croudet]

JNA version 5.1.0 and current

jna/contrib/platform/src/com/sun/jna/platform/unix/X11.java

Line 1756 in 7ac44fe

class XResizeRequestEvent extends Structure {

The field order annotation for XResizeRequestEvent has too much fields.

@FieldOrder({"type", "serial", "send_event", "display", "parent", "window", "x", "y", "width", "height", "border_width", "above", "detail", "value_mask"})
    class XResizeRequestEvent extends Structure {
        public int type;
        public NativeLong serial;   // # of last request processed by server
        public int send_event;      // true if this came from a SendEvent request
        public Display display;     // Display the event was read from
        public Window window;
        public int width, height;
    }

[matthiasblaesing]

I created PR #1047 - it adds unittests for all X11 structures and found the problem you found. It seems to be the only one and will be fixed with that PR.

[croudet]

Thanks.

The only other thing I noticed is a duplicate field order declaration (annotation and createFieldOrder method call):

    @FieldOrder({"type", "serial", "send_event", "display", "window"})
    public static class XAnyEvent extends Structure {
        public static final List<String> FIELDS = createFieldsOrder();

[matthiasblaesing]

Thank you for checking - there are more instances, that show the remains of the old code. These are left overs from the conversion. The code is not used - the static field would need to be returned from getFieldOrder and that is not the case. However it should be cleaned up and this is done now with the second commit.