-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Linux LibC.Sysinfo FieldOrder #1028
Conversation
New build.xml confirmed Linux test failure:
|
Well, Linux test passes but Mac is failing with the new build for other reasons that I don't quite understand... |
Seems to be running (and failing) the Unix tests on Mac. |
contrib/platform/build.xml
Outdated
<condition property="tests.platform.linux" value="**/linux/**/*Test.java"> | ||
<os name="Linux"/> | ||
</condition> | ||
<condition property="tests.platform.unix" value="**/unix/**/*Test.java"> | ||
<os family="unix"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change this line to read:
<and>
<os family="unix"/>
<not><os family="mac"/></not>
</and>
That way the unix tests are not run on Mac OS (as it was before the change)
Thank you for updating the PR, could you please revert the changes to the toplevel |
Sure, I'll undo it... sorry, ended up editing the wrong build.xml trying to fix a tab-to-spaces thing. |
OK, I think I have it fixed now. Editing on Notepad++ pre-coffee was maybe not the smartest thing to do. |
Fixes #1027.
Committing build.xml patch first to generate test failure before fixing it.