Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mapping for X11 generic events #1260

Closed
wants to merge 3 commits into from

Conversation

lafoletc
Copy link
Contributor

@lafoletc lafoletc commented Oct 30, 2020

@lafoletc lafoletc changed the title Add generic events Add X11 generic events Oct 31, 2020
@matthiasblaesing
Copy link
Member

Could you please point to the definition/headerfiles for the structures? That would help to review.

For the commit please check the author settings. The committer email looks sane, but for the author name only your firstname is set. To fix the existing commits, please squash them and update the author information while doing so.

Please also add an enhancement entry to the CHANGES.md entry. Have a look at the existing entries as template.

Thanks.

@lafoletc lafoletc changed the title Add X11 generic events Add mapping for X11 generic events Nov 2, 2020
@dbwiddis
Copy link
Contributor

dbwiddis commented Nov 2, 2020

The structures are already defined in X11 (Display is just a decorated PointerType), and match here.

Is it possible to create a test case to exercise these functions? Looks like sample code at the above manpage link.

@matthiasblaesing
Copy link
Member

Merged via 8f17bdd

I finished the squash and fixed a remaining problem checkstyle complained about.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants