GetLogicalProcessorInformation and associated structs #225
Conversation
|
|
||
| public final void testGetLogicalProcessorInformation() { | ||
| WinNT.SYSTEM_LOGICAL_PROCESSOR_INFORMATION informationArray = Kernel32Util.getLogicalProcessorInformation(); | ||
| assertTrue(informationArray >= 1); // docs say so |
There was a problem hiding this comment.
Does this even compile? I was expecting to see informationArray.length >= 1.
There was a problem hiding this comment.
Crap. I bet it doesn't. I can't tell because the test code already couldn't compile before I got here (it's looking for StructureFieldOrderTest and can't find it. I went looking for it too and I can't find it either.) :)
There was a problem hiding this comment.
StructureFieldOrderTest is linux-only; I've refactored the contrib tests to properly compile/run only on their respective platforms.
There was a problem hiding this comment.
This class compiles now. Although even after merging, I still see StructureFieldOrderTest failing to build, now I'm sitting on Mac OS, not on Windows. Well, at least no compilation errors show Kernel32UtilTest anymore, so things are probably OK.
Pulling master back to get compilation fixes.
|
What version OSX and Java? I'm building on 10.6.8 w/ Xcode 3.2.6 and 10.8.x w/ Xcode 4. StructureFieldTest is supposed to be limited to linux builds. |
|
10.8.2 and Java 1.6.0_41 (not using Xcode, just the command-line) |
|
I'm not actually using Xcode, but that's usually where |
|
Merged in 8e44c82, with some minor updates (@trejkaz, please review). Thank you. |
…on and upgrade (java-native-access#225) Motivation: Newer versions of dawidd6/action-download-artifact changed the default workflow_conclusion from "completed" to "completed, success" which can result in download failures if the associated job fails, which is expected when tests fail. Modifications: - Explicitly set the workflow_conclusion to "completed" - Update to new version Result: Test failures which result in build failures will still download test data and generate reports after updating dawidd6/action-download-artifact.
If you want to find out the true number of processor cores on Windows, it looks like this is the most straight-forward way...