Exception chaining for com.sun.jna.Structure #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is a good idea, @twall should comment/merge. |
|
LGTM. Feel free to merge after test. On Dec 11, 2013, at 9:00 AM, Daniel Doubrovkine (dB.) notifications@github.com wrote:
|
|
@ebourg Please add a CHANGES.md entry and this is good to merge. |
|
Thank you, I rebased the modification on the current HEAD and added an entry in CHANGES.md |
twall
added a commit
that referenced
this pull request
Apr 10, 2014
Exception chaining for com.sun.jna.Structure
mstyura
pushed a commit
to mstyura/jna
that referenced
this pull request
Sep 9, 2024
…cess#290) Motivation: We sometimes saw failures as we were not able to reserve enough memory to unpack the rust toolchain on windows. Like: ``` info: using up to 500.0 MiB of RAM to unpack components info: installing component 'rustfmt' info: installing component 'cargo' info: installing component 'rust-std' info: installing component 'rustc' memory allocation of 16777216 bytes failed Error: The process 'C:\Rust\.cargo\bin\rustup.exe' failed with exit code 3221226505 ``` Modifications: Set env to limit to 128MiB Result: More stable builds on windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'd like to suggest using exception chaining in
com.sun.jna.Structureto improve the stacktraces produced when an error occurs.IllegalArgumentException(String, Throwable)was introduced in Java 5, so this change is compatible with the minimum version of Java currently supported by JNA.Thank you