Added Advapi32Util accessCheck method to verify file permissions #301
Conversation
| * @param AccessMask [in, out] A pointer to an access mask. | ||
| * @param GenericMapping [in] A pointer to a GENERIC_MAPPING structure specifying a mapping of generic access types to specific and standard access types. | ||
| */ | ||
| public void MapGenericMask(WinDef.DWORDByReference AccessMask, WinNT.GENERIC_MAPPING GenericMapping); |
There was a problem hiding this comment.
Import the structures used and change things like WinDef.DWORDByRference to just DWORDByReference.
|
This is very good. You need to add lower level tests for |
|
AccessCheck is very involved so basically I think the higher level test is the lowest level test you can get for this |
|
I am happy with whatever test that calls the API and doesn't implode. |
|
I believe I've address all your concerns. Let me know if there is anything else to look at. |
| @@ -18,6 +18,7 @@ Features | |||
| * [#250](https://github.com/twall/jna/pull/250): Added `com.sun.jna.platform.win32.Kernel32.GetPrivateProfileSection`, `GetPrivateProfileSectionNames` and `WritePrivateProfileSection` and corresponding `Kernel32Util` helpers - [@quipsy-karg](https://github.com/quipsy-karg). | |||
| * [#287](https://github.com/twall/jna/pull/287): Added `DBTF_MEDIA` and `DBTF_NET` to `com.sun.jna.platform.win32.DBT` - [@daifei4321](https://github.com/daifei4321). | |||
| * [#295](https://github.com/twall/jna/pull/295): Added `com.sun.jna.platform.win32.Kernel32.ResetEvent` - [@manithree](https://github.com/manithree). | |||
| * [#301](https://github.com/twall/jna/pull/301): Added `com.sun.jna.platform.win32.Advapi32Util.accessCheck` and supporting classes/methods to verify file permissions - [@BusyByte] (https://github.com/BusyByte/jna). | |||
There was a problem hiding this comment.
There's an extra space after [@BusyByte] that makes it a non-link. You should also add the mappings that you added as a separate line like above.
|
I still don't see a test for |
…dated changelog markup
|
I get back invalid handle. Take a look and see if there is anything else I need to do. |
| assertFalse(status); | ||
| assertFalse(result.getValue().booleanValue()); | ||
|
|
||
| assertEquals("The handle is invalid.", Kernel32Util.formatMessage(W32Errors.HRESULT_FROM_WIN32(Kernel32.INSTANCE.GetLastError()))); |
There was a problem hiding this comment.
Last thing, promise. Just check that Kernel32.INSTANCE.GetLastError() is INVALID_HANDLE or something like that. This would fail on a non-US-English system.
…s and general cleanup
|
Alright let me know how it looks now. |
|
Great, merging. |
Added Advapi32Util accessCheck method to verify file permissions
Bumps logback-classic from 1.1.7 to 1.2.0. --- updated-dependencies: - dependency-name: ch.qos.logback:logback-classic dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
I had contacted you on the Google Group about adding this functionality to check effective file permissions for the current user.
I've added three tests to verify the positive cases.
I couldn't think of an automated way to test the negative cases so I just manually tested those and deleted the tests for those.
Let me know if you have any questions.
Can you message me back on the Google Group when you have Maven Central updated with a new release with these changes?
Shawn