User32: Added LockWorkStation, ExitWindowsEx, AdjustWindowRect[Ex], and Get/SetWindowPlacement #339
Conversation
Get/SetWindowPlacement. WinUser: Added ExitWindows codes, Window Style codes, and the WindowPlacement structure.
| } | ||
|
|
||
| public final void testLockWorkStation() { | ||
| // Skipped by default because it locks the screen, which is generally undesirable during unit testing. |
There was a problem hiding this comment.
I think the "better" way of doing this is to use ignore. Or maybe to mark the test private (I think it doesn't run in that case).
There was a problem hiding this comment.
In order to use ignore we would need to use JUnit 4's style; instead of TestCase subclasses with testXXXX() methods, classes that are standalone and whose methods use @test annotations. Is it okay to convert this, then?
There was a problem hiding this comment.
If that just works (we rely on JUnit 4 right?) then totally.
|
This is great, see comments above. Please also update CHANGES. |
|
Should be ready to go now I think. |
|
The command line build is broken with this, it would need to be fixed, too. Run |
|
Had trouble actually building on my machine -- even with the old version, I think I have something misconfigured -- but I believe the problem ought be fixed by just updating the JUnit jar from 3.8 to 4.1. Also fixed two uses of a <> generic which wouldn't build. |
|
Merged via 6379317?w=1 |
…-access#339) Motivation: The toString() method of QuicConnectionAddress did produce a not so useful string representation. Modifications: Use a hexdump presentation of the id Result: Fixes netty/netty-incubator-codec-quic#338
WinUser: Added ExitWindows codes, Window Style codes, and the
WindowPlacement structure.